IGNITE-27900 Use message serializer for CacheStatisticsClearMessage, ChangeGlobalStateMessage, DynamicCacheChangeBatch, ClientCacheChangeDummyDiscoveryMessage by abashev · Pull Request #12780 · apache/ignite

abashev · 2026-02-19T21:25:30Z

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

shishkovilja · 2026-02-25T07:53:48Z

...e/src/main/java/org/apache/ignite/internal/processors/cache/CacheStatisticsClearMessage.java

@@ -41,13 +46,23 @@ public class CacheStatisticsClearMessage implements DiscoveryCustomMessage {
    private final IgniteUuid id = IgniteUuid.randomUuid();


All non-transient, non-static fields should be serialized. Also, inititalization of UUID can be moved to non default constructor.

anton-vinogradov · 2026-03-17T10:57:57Z

...java/org/apache/ignite/internal/processors/cache/ClientCacheChangeDummyDiscoveryMessage.java

+    Map<String, DynamicCacheChangeRequest> startReqs;
+
+    /** */
+    @Order(value = 1, method = "startRequestsBytes")


Use MarshallableMessage instead

anton-vinogradov · 2026-03-17T14:24:54Z

...java/org/apache/ignite/internal/processors/cache/ClientCacheChangeDummyDiscoveryMessage.java


+    /** {@inheritDoc} */
+    @Override public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
+        if (startReqs != null && startRequestsBytes == null)


Any reason to check startRequestsBytes == null?

github-actions · 2026-03-19T08:25:04Z

Possible compatibility issues. Please, check rolling upgrade cases

This PR modifies protected classes (with Order annotation).
Changes to these classes can break rolling upgrade compatibility.

Affected files:

modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryCustomEventMessage.java

shishkovilja · 2026-03-19T08:38:46Z

...c/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryCustomEventMessage.java

    // TODO: Should be removed in https://issues.apache.org/jira/browse/IGNITE-27627
    public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
-        if (msg instanceof Message)
+        if (msg instanceof Message) {


MarshallableMessage will be properly processed in MessageSerializer, this change is unnecessary.

shishkovilja · 2026-03-19T08:38:54Z

...c/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryCustomEventMessage.java

            return;

-        if (serMsg != null)
+        if (serMsg != null) {


MarshallableMessage will be properly processed in MessageSerializer, this change is unnecessary.

shishkovilja · 2026-03-19T08:41:32Z

modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java

        super(false);
    }

+    /**


Why do we need this change in this PR?

shishkovilja · 2026-03-19T08:41:41Z

modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoverySelfTest.java

            // (possibly due to http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7122846).
-            if (U.isMacOs())
-                spi.setLocalAddress(F.first(U.allLocalIps()));
+            if (U.isMacOs()) {


Why o we need this change in this PR?

shishkovilja · 2026-03-19T08:43:12Z

modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java


            msg = metricsMsgFilter.pollActualMessage(laps, msg);

+            // pollActualMessage() can return null when actualFirstLapMetricsUpdate or actualSecondLapMetricsUpdate


Are there any existing NPE case?

shishkovilja · 2026-03-19T08:53:04Z

modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryIoSession.java


        try {
+            if (msg instanceof MarshallableMessage)
+                ((MarshallableMessage)msg).prepareMarshal(spi.marshaller());


This already will be done in corresponding MessageSerializer, why do we need this?

# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheStatisticsClearMessage.java

# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java

…ryMessage # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java

# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java

sonarqubecloud · 2026-03-24T14:20:38Z

Quality Gate failed

Failed conditions
9 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

abashev force-pushed the feature/IGNITE-27900 branch 2 times, most recently from 3325785 to f039f49 Compare February 24, 2026 15:27

shishkovilja reviewed Feb 25, 2026

View reviewed changes

abashev force-pushed the feature/IGNITE-27900 branch from f039f49 to 5f6f3fa Compare March 3, 2026 15:44

abashev requested a review from shishkovilja March 3, 2026 15:52

abashev force-pushed the feature/IGNITE-27900 branch from 5f6f3fa to 8bef005 Compare March 4, 2026 08:41

abashev changed the title ~~IGNITE-27900 Use message serializer for CacheStatisticsClearMessage~~ Use message serializer for CacheStatisticsClearMessage, ChangeGlobalStateMessage, DynamicCacheChangeBatch Mar 17, 2026

abashev changed the title ~~Use message serializer for CacheStatisticsClearMessage, ChangeGlobalStateMessage, DynamicCacheChangeBatch~~ Use message serializer for CacheStatisticsClearMessage, ChangeGlobalStateMessage, DynamicCacheChangeBatch, ClientCacheChangeDummyDiscoveryMessage Mar 17, 2026

anton-vinogradov reviewed Mar 17, 2026

View reviewed changes

abashev requested a review from anton-vinogradov March 17, 2026 14:02

anton-vinogradov requested changes Mar 17, 2026

View reviewed changes

abashev force-pushed the feature/IGNITE-27900 branch from 39a7d6d to ea4e3a1 Compare March 17, 2026 14:30

abashev requested a review from anton-vinogradov March 17, 2026 14:34

abashev force-pushed the feature/IGNITE-27900 branch from ea4e3a1 to 2de8059 Compare March 17, 2026 19:51

abashev force-pushed the feature/IGNITE-27900 branch from 2de8059 to c9fd669 Compare March 19, 2026 08:24

github-actions bot added the compatibility label Mar 19, 2026

abashev force-pushed the feature/IGNITE-27900 branch from c9fd669 to adc27d0 Compare March 19, 2026 08:35

shishkovilja reviewed Mar 19, 2026

View reviewed changes

abashev added 5 commits March 19, 2026 18:13

Fix errors

d586b18

IGNITE-27957 Use message serializer for ChangeGlobalStateMessage

fcb35fc

# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java

IGNITE-27965 Use message serializer for ClientCacheChangeDummyDiscove…

944a577

…ryMessage # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java

IGNITE-27967 Use message serializer for DynamicCacheChangeBatch

64efce8

# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java

abashev force-pushed the feature/IGNITE-27900 branch from adc27d0 to d7c283a Compare March 19, 2026 15:54

Use MarshallableMessage

8644e44

abashev force-pushed the feature/IGNITE-27900 branch from d7c283a to 8644e44 Compare March 19, 2026 20:13

Merge branch 'master' into feature/IGNITE-27900

b93653f

# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java

anton-vinogradov approved these changes Mar 24, 2026

View reviewed changes

anton-vinogradov merged commit 614974f into apache:master Mar 24, 2026
9 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IGNITE-27900 Use message serializer for CacheStatisticsClearMessage, ChangeGlobalStateMessage, DynamicCacheChangeBatch, ClientCacheChangeDummyDiscoveryMessage#12780

IGNITE-27900 Use message serializer for CacheStatisticsClearMessage, ChangeGlobalStateMessage, DynamicCacheChangeBatch, ClientCacheChangeDummyDiscoveryMessage#12780
anton-vinogradov merged 7 commits intoapache:masterfrom
abashev:feature/IGNITE-27900

abashev commented Feb 19, 2026 •

edited

Loading

Uh oh!

shishkovilja Feb 25, 2026 •

edited

Loading

Uh oh!

anton-vinogradov Mar 17, 2026

Uh oh!

anton-vinogradov Mar 17, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

shishkovilja Mar 19, 2026

Uh oh!

shishkovilja Mar 19, 2026

Uh oh!

shishkovilja Mar 19, 2026

Uh oh!

shishkovilja Mar 19, 2026

Uh oh!

shishkovilja Mar 19, 2026 •

edited

Loading

Uh oh!

shishkovilja Mar 19, 2026

Uh oh!

sonarqubecloud bot commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -41,13 +46,23 @@ public class CacheStatisticsClearMessage implements DiscoveryCustomMessage {
		private final IgniteUuid id = IgniteUuid.randomUuid();


		msg = metricsMsgFilter.pollActualMessage(laps, msg);

		// pollActualMessage() can return null when actualFirstLapMetricsUpdate or actualSecondLapMetricsUpdate

Conversation

abashev commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The Contribution Checklist

Notes

Uh oh!

shishkovilja Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anton-vinogradov Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

anton-vinogradov Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 19, 2026

Possible compatibility issues. Please, check rolling upgrade cases

Uh oh!

shishkovilja Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

shishkovilja Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

shishkovilja Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

shishkovilja Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

shishkovilja Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shishkovilja Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 24, 2026

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abashev commented Feb 19, 2026 •

edited

Loading

shishkovilja Feb 25, 2026 •

edited

Loading

shishkovilja Mar 19, 2026 •

edited

Loading